[clang-tidy][NFC] Enable "HeaderFilterRegex" in clang-tidy codebase #167020
Conversation
vbvictor
requested review from
EugeneZelenko,
HerrCai0907,
carlosgalvezp and
localspook
| @@ -1,4 +1,6 @@ | |||
| InheritParentConfig: true | |||
| HeaderFilterRegex: 'clang-tools-extra/clang-tidy' | |||
| ExcludeHeaderFilterRegex: 'include-cleaner|clang-query' | |||
There was a problem hiding this comment.
Had to do this because I got errors from files like this:
llvm/llvm-project/clang-tools-extra/clang-tidy/misc/../../include-cleaner/include/clang-include-cleaner/Types.h:22:9
So it matched on regex clang-tools-extra/clang-tidy but actually it's header from another subproject.
If anyone have better ideas - please tell!
There was a problem hiding this comment.
I think this is the relevant code:
llvm-project/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
Lines 590 to 594 in 7734276
Maybe we should normalize
FileName before matching on it? i.e.:
clang-tools-extra/clang-tidy/misc/../../include-cleaner/include/clang-include-cleaner/Types.h
->
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.hThere was a problem hiding this comment.
BTW, the reason we have these relative paths in the first place is because include-cleaner forces us to do this:
...which is just really ugly. I've opened #167110 to fix it. (It happens to also fix this problem, but I think there's an underlying problem on our end too.)
There was a problem hiding this comment.
FYI same happens with clang-query headers that also emit relative paths
There was a problem hiding this comment.
Ah, that's right, that PR doesn't fully fix this problem then
EugeneZelenko
left a comment
EugeneZelenko
left a comment
There was a problem hiding this comment.
Looks OK for me, but please wait for other reviewers.
|
I think we can proceed to merge "as is" given CMake changes will take time to be merged, and they won't fix the whole problem. WDYT? |
|
That sounds reasonable, we can merge this |
3 participants
No description provided.